Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready for review] add an option to make sidecar send msg func threadsafe #1757

Merged
merged 3 commits into from
Mar 13, 2024
Merged

[Ready for review] add an option to make sidecar send msg func threadsafe #1757

merged 3 commits into from
Mar 13, 2024

Conversation

darinyu
Copy link
Collaborator

@darinyu darinyu commented Mar 6, 2024

Current send_msg is not threadsafe. This PR add an optional to use lock that guards the shared ressource (stdin of the subprocess).

madhur-ob
madhur-ob previously approved these changes Mar 12, 2024
View reviewed changes
@romain-intel romain-intel merged commit 23d5cbf into master Mar 13, 2024
20 of 34 checks passed
@romain-intel romain-intel deleted the make_sidecar_msg_threadsafe branch March 13, 2024 16:09
saikonen
saikonen approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@saikonen saikonen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to go, default behavior for sidecar messages stays unchanged so assuming that some extensions are going to be using the threadsafe messaging?

edit: seems I was late to the party 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikonen saikonen saikonen approved these changes

@madhur-ob madhur-ob madhur-ob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darinyu @saikonen @madhur-ob @romain-intel